Do not show hidden landmarks #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If an element is hidden, ignore it and any landmark it represents and contains (fixes #80). * Also we can use NodeList.forEach() now.
This was referenced Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hidden(via the HTML5 attribute),visibility: hiddenordisplay: none, ignore it and any landmark it represents and contains (fixes Please don't include hidden landmarks #80).Note: this is unrelated to whether landmarks are
aria-hidden—they will show up (despite the fact that assistive technologies may ignore them). This is by design, and a warning to web authors that a landmark is visually apparent, but hidden from assistive technologies, will be added in due course (for more info on this, consult issue #197).